Use lobstr implementation of object_size #488
Conversation
|
Does this also address posit-dev/positron#478? |
|
Yes! |
There was a problem hiding this comment.
LGTM!
I see you also ported the lobstr tests, which is nice.
Ideally we wouldn't have two implementations, but it seems hard to share it since a package can't depend on harp. Maybe we should split harp into CRAN-able and un-CRAN-able parts. That said there's also no guarantee that lobstr can remain on CRAN in the long term.
We could also have done it the other way around, e.g. using https://github.com/rust-lang/cc-rs to build the lobstr sources as part of our build.
But let's worry about all that if the maintenance of this Rust port turns out to be a burden.
|
It would be nice to use a single source of truth but seemed more work to setup the build system than just porting to rust. The object_size code in lobstr hasn't been changed in 2 years, so I guess it won't be too complicated to maintain the port:
|
Co-authored-by: Lionel Henry <[email protected]>
Implements
object_sizeas a port of the lobstr implementation, which should be more resilient to ALTREP objects, although it also:It fixes issues that can be observed in: posit-dev/positron#4512